[webkit-reviews] review granted: [Bug 239897] [GCC] REGRESSION(r293605): error: cannot convert ‘<brace-enclosed initializer list>’ to ‘unsigned char:3’ in initialization : [Attachment 458842] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Diego Pino <dpino at igalia.com>'s
request for review:
Bug 239897: [GCC] REGRESSION(r293605): error: cannot convert ‘<brace-enclosed
initializer list>’ to ‘unsigned char:3’ in initialization
https://bugs.webkit.org/show_bug.cgi?id=239897

Attachment 458842: Patch

https://bugs.webkit.org/attachment.cgi?id=458842&action=review




--- Comment #6 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 458842
  --> https://bugs.webkit.org/attachment.cgi?id=458842
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458842&action=review

r=me with comment.

> Source/JavaScriptCore/bytecode/MethodOfGettingAValueProfile.h:50
> +    MethodOfGettingAValueProfile() { m_kind = Kind::None; }

Please use initialization list, and annotate it with constexpr.

constexpr MethodOfGettingAValueProfile()
    : m_kind(Kind::None)
{
}