[webkit-reviews] review granted: [Bug 240100] [GPU Process] [iOS] REGRESSION(r293570): Snapshot rendering is not scaled with the device scale factor : [Attachment 458839] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 4 19:14:59 PDT 2022
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 240100: [GPU Process] [iOS] REGRESSION(r293570): Snapshot rendering is not
scaled with the device scale factor
https://bugs.webkit.org/show_bug.cgi?id=240100
Attachment 458839: Patch
https://bugs.webkit.org/attachment.cgi?id=458839&action=review
--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 458839
--> https://bugs.webkit.org/attachment.cgi?id=458839
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=458839&action=review
> Source/WebCore/page/FrameSnapshotting.cpp:124
> - auto buffer = ImageBuffer::create(imageRect.size(), purpose,
scaleFactor, options.colorSpace, options.pixelFormat, { }, { hostWindow });
> + auto buffer = ImageBuffer::create(scaledImageRect.size(), purpose, 1,
options.colorSpace, options.pixelFormat, { }, { hostWindow });
It's odd that ImageBuffer::create() takes a scale factor argument, but
apparently that doesn't behave the way we want?
More information about the webkit-reviews
mailing list