[webkit-reviews] review granted: [Bug 239905] Connecting to GPU process may hang if UI process sends sync message simultaneously : [Attachment 458801] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 239905: Connecting to GPU process may hang if UI process sends sync message
simultaneously
https://bugs.webkit.org/show_bug.cgi?id=239905

Attachment 458801: Patch

https://bugs.webkit.org/attachment.cgi?id=458801&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 458801
  --> https://bugs.webkit.org/attachment.cgi?id=458801
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458801&action=review

r=me with fixes. We may want to do the same for the network process?

> Source/WebKit/ChangeLog:23
> +	   connection initialization. Send the GPUPg connection initialization
result, audit token and

Typo: GPUPg

> Source/WebKit/GPUProcess/GPUProcess.cpp:134
> +    WTFLogAlways("GOT Create gpu process connection");

Should drop.

> Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:374
> +    WTFLogAlways("Create gpu process connection");

Should drop

> Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:132
> +	   if (parentConnection.ignoreInvalidMessageForTesting())

indentation is wrong

> Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:133
> +	       instance->connection().setIgnoreInvalidMessageForTesting();

ditto.

> Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:306
> +    WTFLogAlways("Got didinitialize");

Should drop.