[webkit-reviews] review granted: [Bug 240087] [Apple Pay] REGRESSION(r291588): `appearance: -apple-pay-button` doesn't work with `border-width: 0` : [Attachment 458830] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 4 15:44:11 PDT 2022

Kate Cheney <katherine_cheney at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 240087: [Apple Pay] REGRESSION(r291588): `appearance: -apple-pay-button`
doesn't work with `border-width: 0`

Attachment 458830: Patch


--- Comment #3 from Kate Cheney <katherine_cheney at apple.com> ---
Comment on attachment 458830
  --> https://bugs.webkit.org/attachment.cgi?id=458830

View in context: https://bugs.webkit.org/attachment.cgi?id=458830&action=review

> Source/WebCore/rendering/RenderTheme.cpp:123
> +static bool isApperanceAllowedForAllElements(ControlPart part)

nit: Appearance

> Source/WebCore/rendering/RenderTheme.cpp:127
> +	   return true;

can this be: return part == ApplePayButtonPart?

More information about the webkit-reviews mailing list