[webkit-reviews] review granted: [Bug 240024] REGRESSION (r293427): [ iOS ] http/tests/quicklook/same-origin-xmlhttprequest-allowed.html is a constant crash and failure : [Attachment 458761] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Kate Cheney
<katherine_cheney at apple.com>'s request for review:
Bug 240024: REGRESSION (r293427): [ iOS ]
http/tests/quicklook/same-origin-xmlhttprequest-allowed.html is a constant
crash and failure
https://bugs.webkit.org/show_bug.cgi?id=240024

Attachment 458761: Patch

https://bugs.webkit.org/attachment.cgi?id=458761&action=review




--- Comment #7 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 458761
  --> https://bugs.webkit.org/attachment.cgi?id=458761
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458761&action=review

Looks reasonable to me!

(It would be nice if Alex, Brady, and/or Chris could take a look too)

> Source/WebCore/loader/DocumentLoader.cpp:1217
> +bool DocumentLoader::isLoadingRemoteArchive()

Nit - mark this const?

> Source/WebCore/loader/DocumentLoader.h:507
> +    bool isLoadingRemoteArchive();

(const here too)