[webkit-reviews] review granted: [Bug 239852] ARIA reflection for Element attributes : [Attachment 458777] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 239852: ARIA reflection for Element attributes
https://bugs.webkit.org/show_bug.cgi?id=239852

Attachment 458777: Patch

https://bugs.webkit.org/attachment.cgi?id=458777&action=review




--- Comment #24 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 458777
  --> https://bugs.webkit.org/attachment.cgi?id=458777
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458777&action=review

r=me

> Source/WebCore/dom/Element.cpp:1904
> +static bool isElementReflectionAttribute(const QualifiedName& name)

nit: I would have used `inline` to be extra safe.

> Source/WebCore/dom/ElementRareData.h:152
> +	   if (m_explicitlySetAttrElementsMap.isEmpty())

Shouldn't this be the opposite?
if (!m_explicitlySetAttrElementsMap.isEmpty())