[webkit-reviews] review denied: [Bug 239897] [GCC] REGRESSION(r293605): error: cannot convert ‘<brace-enclosed initializer list>’ to ‘unsigned char:3’ in initialization : [Attachment 458583] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has denied Diego Pino <dpino at igalia.com>'s
request for review:
Bug 239897: [GCC] REGRESSION(r293605): error: cannot convert ‘<brace-enclosed
initializer list>’ to ‘unsigned char:3’ in initialization
https://bugs.webkit.org/show_bug.cgi?id=239897

Attachment 458583: Patch

https://bugs.webkit.org/attachment.cgi?id=458583&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 458583
  --> https://bugs.webkit.org/attachment.cgi?id=458583
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458583&action=review

>> Source/JavaScriptCore/bytecode/MethodOfGettingAValueProfile.h:111
>> +	Kind m_kind { Kind::None };
> 
> I believe this will make the object larger. Can we keep the optimization
under other compilers?

Yes, this needs to be small. So, we need different solution.