[webkit-reviews] review granted: [Bug 240038] [WebAuthn] Remove user gesture requirement for mediation=conditional assertions : [Attachment 458756] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 240038: [WebAuthn] Remove user gesture requirement for
mediation=conditional assertions
https://bugs.webkit.org/show_bug.cgi?id=240038

Attachment 458756: Patch

https://bugs.webkit.org/attachment.cgi?id=458756&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 458756
  --> https://bugs.webkit.org/attachment.cgi?id=458756
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458756&action=review

r=me, but please check the cause of the debug failure.

>
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProx
y.mm:326
> +	       requestContext.get().requestStyle =
ASCredentialRequestStyleAutoFill;

Nit: I'd prefer to check and do an early return if it does NOT respond to the
selector, rather than this form. It's slightly easier to read and a little more
concise.

>
Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:
110
> +    if (!data.processingUserGesture &&
!m_webPageProxy.websiteDataStore().authenticatorManager().isVirtual() &&
data.mediation != MediationRequirement::Conditional)

Nit: It might be slightly more efficient to test the 'data.mediation' condition
before retrieving the websiteDataStore->authenticator and calling its isVirtual
method.