[webkit-reviews] review granted: [Bug 239962] ServiceWorkerRegistration update should fail if called from an installing service worker context : [Attachment 458679] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 239962: ServiceWorkerRegistration update should fail if called from an
installing service worker context
https://bugs.webkit.org/show_bug.cgi?id=239962

Attachment 458679: Patch

https://bugs.webkit.org/attachment.cgi?id=458679&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 458679
  --> https://bugs.webkit.org/attachment.cgi?id=458679
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458679&action=review

> Source/WebCore/workers/service/ServiceWorkerRegistration.cpp:158
> +    if (auto* serviceWorkerGbalScope =
dynamicDowncast<ServiceWorkerGlobalScope>(scriptExecutionContext());
serviceWorkerGbalScope && serviceWorkerGbalScope->serviceWorker().state() ==
ServiceWorkerState::Installing) {

typo: serviceWorkerGbalScope