[webkit-reviews] review granted: [Bug 239933] [macOS] The "Markup Image" services menu item should be gated on image analysis results : [Attachment 458651] Patch

[bugzilla-daemon at webkit.org]

Kate Cheney <katherine_cheney at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 239933: [macOS] The "Markup Image" services menu item should be gated on
image analysis results
https://bugs.webkit.org/show_bug.cgi?id=239933

Attachment 458651: Patch

https://bugs.webkit.org/attachment.cgi?id=458651&action=review




--- Comment #7 from Kate Cheney <katherine_cheney at apple.com> ---
Comment on attachment 458651
  --> https://bugs.webkit.org/attachment.cgi?id=458651
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458651&action=review

> Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:299
> +    if (!page()->preferences().imageAnalysisMarkupEnabled())

Do we need to check for a null page here?