[webkit-reviews] review granted: [Bug 239669] [cssom] Iterating computed style should not include 'all' shorthand : [Attachment 458588] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Oriol Brufau <obrufau at igalia.com>'s
request for review:
Bug 239669: [cssom] Iterating computed style should not include 'all' shorthand
https://bugs.webkit.org/show_bug.cgi?id=239669

Attachment 458588: Patch

https://bugs.webkit.org/attachment.cgi?id=458588&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 458588
  --> https://bugs.webkit.org/attachment.cgi?id=458588
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458588&action=review

> Source/WebCore/css/makeprop.pl:211
> +  if ($name eq "all") {
> +    return 1;
> +  }

Two small thoughts:

1) Is there any way to do this with a property rather than literally hardwiring
"all"?
2) Since this is perl, there is a syntax like:

    return 1 if $name eq "all";