[webkit-reviews] review granted: [Bug 238621] Moving forwards and backwards by sentences across a table results in different breaks in each direction. : [Attachment 456299] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 238621: Moving forwards and backwards by sentences across a table results
in different breaks in each direction.
https://bugs.webkit.org/show_bug.cgi?id=238621

Attachment 456299: Patch

https://bugs.webkit.org/attachment.cgi?id=456299&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 456299
  --> https://bugs.webkit.org/attachment.cgi?id=456299
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456299&action=review

I think we should add a lot more backwards text iterator tests instead of only
testing it indirectly like this. But maybe not in this patch I guess.

> Source/WebCore/editing/TextIterator.cpp:1356
> +    

Should drop that that blank line.

> Source/WebCore/editing/TextIterator.cpp:1364
> +	   // A linefeed breaks words, sentences, and paragraphs.

I know you kept this comment cut down from the longer old one. But the code is
now doing something so obvious I think we can leave even this out. Basically
code now says "if we should emit a newline, emit a newline".