[webkit-reviews] review granted: [Bug 238432] [WebGPU] Implement Queue::writeTexture() according to the spec : [Attachment 456221] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 31 16:36:31 PDT 2022


Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 238432: [WebGPU] Implement Queue::writeTexture() according to the spec
https://bugs.webkit.org/show_bug.cgi?id=238432

Attachment 456221: Patch

https://bugs.webkit.org/attachment.cgi?id=456221&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 456221
  --> https://bugs.webkit.org/attachment.cgi?id=456221
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456221&action=review

> Source/WebGPU/WebGPU/Queue.mm:299
> +    //
file:///Users/mmaxfield/src/GPUWeb/spec/index.html#dom-gpuqueue-writetexture

Oops!

> Source/WebGPU/WebGPU/Queue.mm:487
> +    case WGPUTextureDimension_Force32:
> +	   return;

Is this intentionally blank?


More information about the webkit-reviews mailing list