[webkit-reviews] review granted: [Bug 238430] [WebGPU] Implement CommandEncoder::copyTextureToBuffer() according to the spec : [Attachment 456218] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 31 16:31:10 PDT 2022


Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 238430: [WebGPU] Implement CommandEncoder::copyTextureToBuffer() according
to the spec
https://bugs.webkit.org/show_bug.cgi?id=238430

Attachment 456218: Patch

https://bugs.webkit.org/attachment.cgi?id=456218&action=review




--- Comment #5 from Dean Jackson <dino at apple.com> ---
Comment on attachment 456218
  --> https://bugs.webkit.org/attachment.cgi?id=456218
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456218&action=review

> Source/WebGPU/WebGPU/CommandEncoder.mm:359
> +    // "Let srcTextureDesc be source.texture.[[descriptor]]."

This is the first time I've seen this style of spec inclusion. Do we normally
include quotation marks.

The style I've seen is a link at the top of the function, and then the comments
are simply copied in (with the spec items numbers, if needed)


More information about the webkit-reviews mailing list