[webkit-reviews] review granted: [Bug 238579] Add a heuristic to identify and extract the prominent video element in element fullscreen : [Attachment 456235] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 238579: Add a heuristic to identify and extract the prominent video element
in element fullscreen
https://bugs.webkit.org/show_bug.cgi?id=238579

Attachment 456235: Patch

https://bugs.webkit.org/attachment.cgi?id=456235&action=review




--- Comment #4 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 456235
  --> https://bugs.webkit.org/attachment.cgi?id=456235
Patch

Nit: it appears this heuristic depends on the video element already existing in
the page when fullscreen mode is entered. You may want consider a mutation
observer, or listening for events bubbled up to the fullscreen element itself
(like 'loadstart', 'play' or 'pause') to trigger recalculation of this
heuristic.