[webkit-reviews] review granted: [Bug 236909] [GPU Process] [iOS] Text decoration is always drawn with solid stroke style : [Attachment 456277] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 31 14:10:22 PDT 2022


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 236909: [GPU Process] [iOS] Text decoration is always drawn with solid
stroke style
https://bugs.webkit.org/show_bug.cgi?id=236909

Attachment 456277: Patch

https://bugs.webkit.org/attachment.cgi?id=456277&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 456277
  --> https://bugs.webkit.org/attachment.cgi?id=456277
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456277&action=review

> Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:937
> +    StrokeStyle m_style;

This is currently 4 bytes. Might as well change `enum StrokeStyle` to `enum
StrokeStyle : uint8_t` while you're at it.


More information about the webkit-reviews mailing list