[webkit-reviews] review granted: [Bug 238485] [JSC] Remove ExecutableToCodeBlockEdge : [Attachment 456262] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 238485: [JSC] Remove ExecutableToCodeBlockEdge
https://bugs.webkit.org/show_bug.cgi?id=238485

Attachment 456262: Patch

https://bugs.webkit.org/attachment.cgi?id=456262&action=review




--- Comment #9 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 456262
  --> https://bugs.webkit.org/attachment.cgi?id=456262
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456262&action=review

r=me with some comments.

> Source/JavaScriptCore/heap/Heap.h:1075
> +    struct ScriptExecutableSpaceAndSet {

Nit: Maybe this should be ScriptExecutableSpaceAndSets* since there's more than
one set in here.

> Source/JavaScriptCore/runtime/FunctionExecutable.cpp:76
> +    // If either of CodeBlocks is not marked yet, we will run
output-constraints.

Nit: If either CodeBlock is not marked yet

> Source/JavaScriptCore/runtime/GlobalExecutable.cpp:46
> +	   // If the CodeBlocks is not marked yet, we will run
output-constraints.

Nit: not plural. It should be CodeBlock.