[webkit-reviews] review granted: [Bug 238618] RemoteRenderingBackendProxy fails to maintain correct state when gpu process crashes and upon deletion : [Attachment 456257] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 31 12:12:04 PDT 2022


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 238618: RemoteRenderingBackendProxy fails to maintain correct state when
gpu process crashes and upon deletion
https://bugs.webkit.org/show_bug.cgi?id=238618

Attachment 456257: Patch

https://bugs.webkit.org/attachment.cgi?id=456257&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 456257
  --> https://bugs.webkit.org/attachment.cgi?id=456257
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456257&action=review

> Source/WebKit/ChangeLog:3
> +	   RemoteRenderingBackendProxy fails to maintain correct state when gpu
process crashes and upon deletion

But this doesn't fix the issue where the GPU Process crashes while we're
blocked on the m_wakeUpSemaphore, right?

> Source/WebKit/Platform/IPC/MessageReceiveQueueMap.cpp:64
> +	       ALWAYS_LOG_WITH_STREAM(stream <<
"MessageReceiveQueueMap::addImpl - adding duplicate any id receiver " <<
static_cast<uint8_t>(receiverName));

When debugging I wanted a TextStream& operator<<(TextStream&, ReceiverName).
Maybe we should add one, or do some kind of IPC::description() thing that makes
them easy to print.


More information about the webkit-reviews mailing list