[webkit-reviews] review granted: [Bug 238409] [XCBuild] WebKitLegacy's "Migrated headers" script does not emit task information : [Attachment 456185] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Elliott Williams
<emw at apple.com>'s request for review:
Bug 238409: [XCBuild] WebKitLegacy's "Migrated headers" script does not emit
task information
https://bugs.webkit.org/show_bug.cgi?id=238409

Attachment 456185: Patch

https://bugs.webkit.org/attachment.cgi?id=456185&action=review




--- Comment #13 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 456185
  --> https://bugs.webkit.org/attachment.cgi?id=456185
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456185&action=review

> Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj:697
> +			filePatterns = "*/Source/WebCore/*.h";

As discussed in person, I'm confused about how this worked before. WebKitLegacy
couldn't pull headers directly from Source/WebCore until semi-recently.

> Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj:706
> +				"$(HEADER_OUTPUT_DIR)/$(INPUT_FILE_NAME)",
> +			       
"$(DERIVED_FILE_DIR)/WebCore/$(INPUT_FILE_NAME)",

Not excited about creating two files with the same name, as always.