[webkit-reviews] review granted: [Bug 238591] Add more push-related logging : [Attachment 456204] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 31 06:44:15 PDT 2022
youenn fablet <youennf at gmail.com> has granted Ben Nham <nham at apple.com>'s
request for review:
Bug 238591: Add more push-related logging
https://bugs.webkit.org/show_bug.cgi?id=238591
Attachment 456204: Patch
https://bugs.webkit.org/attachment.cgi?id=456204&action=review
--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 456204
--> https://bugs.webkit.org/attachment.cgi?id=456204
Patch
r=me once bots are happy.
View in context: https://bugs.webkit.org/attachment.cgi?id=456204&action=review
> Source/WebCore/Modules/push-api/PushManager.cpp:143
> + RELEASE_LOG(Push, "Failing PushManager.subscribe call due to
failed transient activation check; last activated %.2f sec ago",
lastActivationDuration.value());
RELEASE_LOG_ERROR
> Source/WebCore/workers/service/server/SWServer.cpp:1287
> + RELEASE_LOG(Push, "Cannot process push message: Failed to find
SW registration for registration key %s",
registrationKey.loggingString().utf8().data());
RELEASE_LOG_ERROR
> Source/WebCore/workers/service/server/SWServer.cpp:1294
> + RELEASE_LOG(Push, "Cannot process push message: No active worker
for registration key %s", registrationKey.loggingString().utf8().data());
RELEASE_LOG_ERROR
> Source/WebKit/NetworkProcess/NetworkProcess.cpp:2305
> + RELEASE_LOG(Push, "NetworkProcess getting pending push messages for
session ID %" PRIu64, sessionID.toUInt64());
Is this one really useful?
> Source/WebKit/NetworkProcess/NetworkProcess.cpp:2310
> + RELEASE_LOG_ERROR(Push, "NetworkProcess could not find session for ID
%llu to get pending push messages", sessionID.toUInt64());
Ditto.
> Source/WebKit/NetworkProcess/NetworkProcess.cpp:2332
> + RELEASE_LOG_ERROR(Push, "Networking process asked to handle a push
message from UI process in session %llu, but that session doesn't exist",
sessionID.toUInt64());
We generally do not release log missing session errors.
More information about the webkit-reviews
mailing list