[webkit-reviews] review granted: [Bug 238532] Implement units for CSS typed om : [Attachment 456136] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 238532: Implement units for CSS typed om
https://bugs.webkit.org/show_bug.cgi?id=238532

Attachment 456136: Patch

https://bugs.webkit.org/attachment.cgi?id=456136&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 456136
  --> https://bugs.webkit.org/attachment.cgi?id=456136
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456136&action=review

> Source/WebCore/ChangeLog:3
> +	   Implement units for CSS typed om

"CSS Typed OM"

> Source/WebCore/css/typedom/CSSUnitValue.cpp:81
> +    if (unit == "number"_s)

Case sensitive comparison is OK?

> Source/WebCore/css/typedom/CSSUnitValue.h:59
> +    CSSUnitType m_unit;

This can be const

> Source/WebCore/css/typedom/numeric/CSSMathSum.cpp:39
> +static std::optional<CSSNumericType> addTypes(CSSNumericType a,
CSSNumericType b)

You used const CSSNumericType& arguments for multiply.

> Source/WebCore/css/typedom/numeric/CSSMathSum.cpp:67
> +ExceptionOr<Ref<CSSMathSum>> CSSMathSum::create(FixedVector<CSSNumberish>
numberishes)

const FixedVector&?

> Source/WebCore/css/typedom/numeric/CSSMathSum.cpp:72
> +ExceptionOr<Ref<CSSMathSum>> CSSMathSum::create(Vector<Ref<CSSNumericValue>>
values)

const Vector&?