[webkit-reviews] review granted: [Bug 238187] Add a debug overlay for interaction regions : [Attachment 455345] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 238187: Add a debug overlay for interaction regions
https://bugs.webkit.org/show_bug.cgi?id=238187

Attachment 455345: Patch

https://bugs.webkit.org/attachment.cgi?id=455345&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 455345
  --> https://bugs.webkit.org/attachment.cgi?id=455345
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455345&action=review

r=me (with a build fix for CMake)

> Source/WebCore/dom/Node.cpp:2519
> +    for (const auto& eventType : eventTypes()) {
> +	   if (eventNames().isTouchRelatedEventType(eventType, *this))
> +	       return true;
> +    }
> +    return false;

(Could consider using `containsIf` here — might be a tiny bit cleaner)

> Source/WebCore/page/DebugPageOverlays.cpp:265
> +    Vector<Setting> m_settings {

FixedVector?

> Source/WebCore/page/FrameSnapshotting.cpp:189
> +    for (; !!renderer; renderer = renderer->parent()) {

Could we use `ancestorsOfType<RenderElement>` here?

> Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:40
> +    _WKInteractionRegion = 1 << 4,

Does this need availability information too?