[webkit-reviews] review denied: [Bug 238482] Build failure with g++ 12: DMIs before end of enclosing class : [Attachment 456169] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 30 14:14:54 PDT 2022


Alex Christensen <achristensen at apple.com> has denied Mike Gorse
<mgorse at suse.com>'s request for review:
Bug 238482: Build failure with g++ 12: DMIs before end of enclosing class
https://bugs.webkit.org/show_bug.cgi?id=238482

Attachment 456169: Patch.

https://bugs.webkit.org/attachment.cgi?id=456169&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 456169
  --> https://bugs.webkit.org/attachment.cgi?id=456169
Patch.

Comma location and indentation is not WebKit style even though style bot can't
figure that out.

I'm not a big fan of this fix (removing initializer lists and adding more
explicit constructors is a step in the wrong direction in my opinion).	Is
there an alternative fix at the instantiation site?


More information about the webkit-reviews mailing list