[webkit-reviews] review granted: [Bug 238494] REGRESSION(r290360): [GLX] Crash on process exit : [Attachment 456099] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 238494: REGRESSION(r290360): [GLX] Crash on process exit
https://bugs.webkit.org/show_bug.cgi?id=238494

Attachment 456099: Patch

https://bugs.webkit.org/attachment.cgi?id=456099&action=review




--- Comment #12 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 456099
  --> https://bugs.webkit.org/attachment.cgi?id=456099
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456099&action=review

> Source/WebCore/ChangeLog:13
> +	   PlatformDisplay, which is always the shared one, we can just install
an atexit handler in the constrcutor to

constructor

> Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp:77
> +    // In X11 only one PlatformDisplay instance is allowed per process which
is the sharedDisplay one.

Is there an assert for this already? I'd like to see an assert to enforce this,
or else at least ensure the exit handler is registered called only once.

> Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp:82
> +    std::atexit([] {
> +	PlatformDisplay::sharedDisplay().clearSharingGLContext();

Indentation is wrong:

ERROR: Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp:82:	Tab
found; better to use spaces  [whitespace/tab] [1]