[webkit-reviews] review granted: [Bug 238542] [CSS Container Queries] Keep colon syntax when serializing container condition : [Attachment 456116] Patch

[bugzilla-daemon at webkit.org]

Tim Nguyen (:ntim) <ntim at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 238542: [CSS Container Queries] Keep colon syntax when serializing
container condition
https://bugs.webkit.org/show_bug.cgi?id=238542

Attachment 456116: Patch

https://bugs.webkit.org/attachment.cgi?id=456116&action=review




--- Comment #5 from Tim Nguyen (:ntim) <ntim at apple.com> ---
Comment on attachment 456116
  --> https://bugs.webkit.org/attachment.cgi?id=456116
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456116&action=review

> Source/WebCore/css/ContainerQuery.cpp:164
> +    case Syntax::Range:

Maybe assert that at least one of leftComparison or rightComparison is present.