[webkit-reviews] review granted: [Bug 238311] [WebGPU] Implement Texture::createView() according to the spec : [Attachment 455887] Patch

[bugzilla-daemon at webkit.org]

Kimmo Kinnunen <kkinnunen at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 238311: [WebGPU] Implement Texture::createView() according to the spec
https://bugs.webkit.org/show_bug.cgi?id=238311

Attachment 455887: Patch

https://bugs.webkit.org/attachment.cgi?id=455887&action=review




--- Comment #8 from Kimmo Kinnunen <kkinnunen at apple.com> ---
Comment on attachment 455887
  --> https://bugs.webkit.org/attachment.cgi?id=455887
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455887&action=review

> Source/WebGPU/WebGPU/Texture.mm:1795
> +	   // "set resolved.mipLevelCount to
texture.[[descriptor]].mipLevelCount â resolved.baseMipLevel."

non-ascii chars in comment

> Source/WebGPU/WebGPU/Texture.mm:1841
> +	       // "Set resolved.arrayLayerCount to
texture.[[descriptor]].size.depthOrArrayLayers â baseArrayLayer."

non-ascii

> Source/WebGPU/WebGPU/Texture.mm:2031
> +    std::optional<MTLPixelFormat> pixelFormat = MTLPixelFormatInvalid;

Either:
  std::optional<MTLPixelFormat> pixelFormat;
or:
  MTLPixelFormat pixelFormat = MTLPixelFormatInvalid;

not both?