[webkit-reviews] review granted: [Bug 238533] Web Inspector: Sources: the mapped file URL of a Response Local Override should be clickable : [Attachment 456084] [fast-cq] Patch

[bugzilla-daemon at webkit.org]

Patrick Angle <pangle at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 238533: Web Inspector: Sources: the mapped file URL of a Response Local
Override should be clickable
https://bugs.webkit.org/show_bug.cgi?id=238533

Attachment 456084: [fast-cq] Patch

https://bugs.webkit.org/attachment.cgi?id=456084&action=review




--- Comment #2 from Patrick Angle <pangle at apple.com> ---
Comment on attachment 456084
  --> https://bugs.webkit.org/attachment.cgi?id=456084
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456084&action=review

rs=me with one suggestion – also the build failures on GTK and others look
real.

> Source/WebCore/ChangeLog:11
> +	   (WebCore::InspectorFrontendHost::selectFileExternally): Added.

Just one overarching question throughout: can we consider naming this
`revealFileExternally` (and changing all the other method names to match)?
Perhaps that is too much Mac influence here, but in general I see this sort of
action behind a "Reveal in [...]" menu item in apps. `select`, in my opinion,
is somewhat ambiguous with showing a file chooser to let someone choose (or
"select") a file.