[webkit-reviews] review granted: [Bug 238498] Implement persistent notification handling : [Attachment 456014] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 238498: Implement persistent notification handling
https://bugs.webkit.org/show_bug.cgi?id=238498

Attachment 456014: Patch

https://bugs.webkit.org/attachment.cgi?id=456014&action=review




--- Comment #6 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 456014
  --> https://bugs.webkit.org/attachment.cgi?id=456014
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456014&action=review

>> Source/WebCore/Modules/notifications/Notification.cpp:69
>> +	notification->showSoon();
> 
> Looking at it again, calling showSoon should be removed. Probably worth
moving showSoon call out of the Notification::create object.

Definitely should be: In this case we're not showing it.

Agree with the refactor.

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:2332
>  
> +

stray newline