[webkit-reviews] review granted: [Bug 238346] Web Inspector: Support Container Queries in the Styles sidebar : [Attachment 456050] Patch v1.1 - Rebase on CSSContainerRule implementation

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 238346: Web Inspector: Support Container Queries in the Styles sidebar
https://bugs.webkit.org/show_bug.cgi?id=238346

Attachment 456050: Patch v1.1 - Rebase on CSSContainerRule implementation

https://bugs.webkit.org/attachment.cgi?id=456050&action=review




--- Comment #10 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 456050
  --> https://bugs.webkit.org/attachment.cgi?id=456050
Patch v1.1 - Rebase on CSSContainerRule implementation

View in context: https://bugs.webkit.org/attachment.cgi?id=456050&action=review

r=me, awesomeness =D

Could you please upload a screenshot of this change?  I'm 99% sure I know what
this will look like, but it'd be nice to know for sure (plus we may wanna have
some extra styling, e.g. maybe we emphasize the container name?).

> Source/WebCore/inspector/InspectorStyleSheet.cpp:134
> +	       // These rule types do not contain child rules that are
displayed in Web Inspector's Style Details Sidebar for elements.

NIT: this sentence is a bit awkward to read
```
// These rule types do not contain child rules, and therefore have nothing to
display in the Styles panel in the details sidebar of the Elements Tab in Web
Inspector.
```

> LayoutTests/inspector/css/getMatchedStylesForNodeContainerGrouping.html:155
> +    @container notUsedName (width >= 200px) {

NIT: Should we try some other conditions?  Maybe some style containers
(assuming we support them)?