[webkit-reviews] review granted: [Bug 238510] [LibWPE] Guard libxkbcommon code with WPE_ENABLE_XKB : [Attachment 456040] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 238510: [LibWPE] Guard libxkbcommon code with WPE_ENABLE_XKB
https://bugs.webkit.org/show_bug.cgi?id=238510

Attachment 456040: Patch

https://bugs.webkit.org/attachment.cgi?id=456040&action=review




--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 456040
  --> https://bugs.webkit.org/attachment.cgi?id=456040
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456040&action=review

> Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.cpp:152
>      struct wpe_input_xkb_keymap_entry* entries;

Meh. Too bad we don't have something like GUniqueOutPtr which would
call free() instead of g_free(); it would have been perfect to use
here instead of having the one line of guarded code below ��‍♂️️