[webkit-reviews] review granted: [Bug 238465] WebCore::LegacyRootInlineBox::lineSnapAdjustment should bail out on grid line height < 1 : [Attachment 455947] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 238465: WebCore::LegacyRootInlineBox::lineSnapAdjustment should bail out on
grid line height < 1
https://bugs.webkit.org/show_bug.cgi?id=238465

Attachment 455947: Patch

https://bugs.webkit.org/attachment.cgi?id=455947&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 455947
  --> https://bugs.webkit.org/attachment.cgi?id=455947
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455947&action=review

> Source/WebCore/rendering/LegacyRootInlineBox.cpp:363
> -    if (!gridLineHeight)
> +    if (gridLineHeight < 1)

could this be 

if (!roundToInt(gridLineHeight))

?