[webkit-reviews] review granted: [Bug 238466] REGRESSION(r291771): [ iOS ] Glyphs should only be recorded after setting the destination GraphicsContext : [Attachment 455986] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 238466: REGRESSION(r291771): [ iOS ] Glyphs should only be recorded after
setting the destination GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=238466

Attachment 455986: Patch

https://bugs.webkit.org/attachment.cgi?id=455986&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 455986
  --> https://bugs.webkit.org/attachment.cgi?id=455986
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455986&action=review

Are there any tests that have been marked as flakey that this fixes?

> Source/WebCore/ChangeLog:3
> +	   REGRESSION(r291771): [ iOS ] Glyphs should only be recorded after
setting the destination GraphicsContext

It's good if the bug title describes the user-visible symptom (e.g. "Text
sometimes draw with incorrect color").