[webkit-reviews] review granted: [Bug 186919] Navigation Timing data is corrupt in WebView (UIWebView/WKWebView) : [Attachment 455946] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 186919: Navigation Timing data is corrupt in WebView (UIWebView/WKWebView)
https://bugs.webkit.org/show_bug.cgi?id=186919

Attachment 455946: Patch

https://bugs.webkit.org/attachment.cgi?id=455946&action=review




--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 455946
  --> https://bugs.webkit.org/attachment.cgi?id=455946
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455946&action=review

> Source/WebCore/platform/network/cocoa/NetworkLoadMetrics.mm:57
> +    // Sometimes in production responseStart is before requestStart,
possibly due to clock updates. If this happens, use the later of the two.

I don't think "in production" adds anything here. Should we reference a radar?