[webkit-reviews] review granted: [Bug 238462] [macOS] Muted video is sometimes paused when entering fullscreen : [Attachment 455937] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 238462: [macOS] Muted video is sometimes paused when entering fullscreen
https://bugs.webkit.org/show_bug.cgi?id=238462

Attachment 455937: Patch

https://bugs.webkit.org/attachment.cgi?id=455937&action=review




--- Comment #4 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 455937
  --> https://bugs.webkit.org/attachment.cgi?id=455937
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455937&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:6058
> +#if ENABLE(FULLSCREEN_API)
> +    auto& fullscreenManager = document().fullscreenManager();
> +    if (isVideo() && fullscreenManager.isFullscreen() &&
fullscreenManager.currentFullscreenElement())
> +	   return false;
> +#endif
> +
> +    if (m_videoFullscreenMode != VideoFullscreenModeNone)
> +	   return false;
> +
> +    return document().hidden();

I think this is incorrect long-term, insofar as element fullscreen on a
background space (on macOS) shouldn't always be "visible", but we should file a
bug to follow up later.

> Source/WebCore/html/HTMLMediaElement.cpp:8344
> +	   queueTaskKeepingObjectAlive(*this, TaskSource::MediaElement, [this]
{
> +	       if (isContextStopped())
> +		   return;
> +	       mediaSession().isVisibleInViewportChanged();
> +	       updateShouldAutoplay();
> +	       schedulePlaybackControlsManagerUpdate();
> +	   });

Is this necessary?