[webkit-reviews] review granted: [Bug 237883] [GTK][WPE] Use GBMBufferSwapchain in GraphicsContextGLTextureMapperANGLE : [Attachment 455914] Patch

[bugzilla-daemon at webkit.org]

Alejandro G. Castro <alex at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 237883: [GTK][WPE] Use GBMBufferSwapchain in
GraphicsContextGLTextureMapperANGLE
https://bugs.webkit.org/show_bug.cgi?id=237883

Attachment 455914: Patch

https://bugs.webkit.org/attachment.cgi?id=455914&action=review




--- Comment #6 from Alejandro G. Castro <alex at igalia.com> ---
Comment on attachment 455914
  --> https://bugs.webkit.org/attachment.cgi?id=455914
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455914&action=review

LGTM! Just check the unguarded line to make sure we do not break other
compilations.

>
Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp
:476
> +    m_swapchain.displayBO = WTFMove(m_swapchain.drawBO);

This needs to be guarded with the TEXTURE_MAPPER_DMABUF. It is causing the
wincairo failure.