[webkit-reviews] review denied: [Bug 238443] [GLIB] Build error in GraphicsContextState.cpp (error: no match for 'operator!=') in Ubuntu LTS after r291696 : [Attachment 455896] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has denied Diego Pino <dpino at igalia.com>'s
request for review:
Bug 238443: [GLIB] Build error in GraphicsContextState.cpp (error: no match for
'operator!=') in Ubuntu LTS after r291696
https://bugs.webkit.org/show_bug.cgi?id=238443

Attachment 455896: Patch

https://bugs.webkit.org/attachment.cgi?id=455896&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 455896
  --> https://bugs.webkit.org/attachment.cgi?id=455896
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455896&action=review

> Source/WebCore/platform/graphics/GraphicsTypes.h:90
> +}

This cannot work, moving the function outside of the “class” block means
that now there is no implicit “this”, and that no operator== is defined
at all for CompositeMode. You need to leave this one as it was.