[webkit-reviews] review denied: [Bug 237674] [GPU Process] window opening tests are intermittently crashing : [Attachment 455788] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 28 01:18:17 PDT 2022


Kimmo Kinnunen <kkinnunen at apple.com> has denied  review:
Bug 237674: [GPU Process] window opening tests are intermittently crashing
https://bugs.webkit.org/show_bug.cgi?id=237674

Attachment 455788: Patch

https://bugs.webkit.org/attachment.cgi?id=455788&action=review




--- Comment #7 from Kimmo Kinnunen <kkinnunen at apple.com> ---
Comment on attachment 455788
  --> https://bugs.webkit.org/attachment.cgi?id=455788
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455788&action=review

> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:111
> +    // the same sequence as RemoteRenderingBackend messages.
m_placeholderDisplayListStreamBufferID is necessary to make this receiver
unique per IPC::Connection.

I don't think the placeholder is used anywhere?
This would amount to the same effect as removing the catch-all altogether.


More information about the webkit-reviews mailing list