[webkit-reviews] review granted: [Bug 238398] [GTK][WPE] Support CSS accent-color : [Attachment 455843] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Mar 26 06:54:47 PDT 2022
Carlos Garcia Campos <cgarcia at igalia.com> has granted Alexander Mikhaylenko
<alexm at gnome.org>'s request for review:
Bug 238398: [GTK][WPE] Support CSS accent-color
https://bugs.webkit.org/show_bug.cgi?id=238398
Attachment 455843: Patch
https://bugs.webkit.org/attachment.cgi?id=455843&action=review
--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 455843
--> https://bugs.webkit.org/attachment.cgi?id=455843
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=455843&action=review
> Source/WebCore/platform/adwaita/ThemeAdwaita.cpp:266
> + if (states.states().contains(ControlStates::States::Hovered)
> + && states.states().contains(ControlStates::States::Enabled))
Use a single line here
> Source/WebCore/platform/adwaita/ThemeAdwaita.cpp:298
> + if (states.states().contains(ControlStates::States::Hovered)
> + && states.states().contains(ControlStates::States::Enabled))
Ditto.
> Source/WebCore/platform/adwaita/ThemeAdwaita.cpp:350
> + if (states.states().contains(ControlStates::States::Hovered)
> + && states.states().contains(ControlStates::States::Enabled))
Ditto.
> Source/WebCore/platform/adwaita/ThemeAdwaita.cpp:367
> + if (states.states().contains(ControlStates::States::Hovered)
> + && states.states().contains(ControlStates::States::Enabled))
Ditto.
More information about the webkit-reviews
mailing list