[webkit-reviews] review granted: [Bug 235027] [JSC][ARMv7] Cleanup GPR numbering : [Attachment 455632] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Geza Lore <glore at igalia.com>'s
request for review:
Bug 235027: [JSC][ARMv7] Cleanup GPR numbering
https://bugs.webkit.org/show_bug.cgi?id=235027

Attachment 455632: Patch

https://bugs.webkit.org/attachment.cgi?id=455632&action=review




--- Comment #6 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 455632
  --> https://bugs.webkit.org/attachment.cgi?id=455632
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455632&action=review

r=me with comments.

> Source/JavaScriptCore/jit/BaselineJITRegisters.h:95
> +    constexpr GPRReg globalObjectGPR = preferredArgumentGPR<SlowOperation,
0>();
> +    constexpr JSValueRegs thrownValueJSR =
preferredArgumentJSR<SlowOperation, 1>();
> +    constexpr GPRReg bytecodeOffsetGPR = GPRInfo::nonArgGPR0;

This change is not necessary.

> Source/JavaScriptCore/llint/LLIntData.h:394
> +#if CPU(ARM)

Use CPU(ARM_THUMB2)

> Source/JavaScriptCore/llint/LLIntData.h:-405
> -#elif CPU(MIPS) || CPU(ARM_THUMB2)

Use CPU(ARM_THUMB2)