[webkit-reviews] review granted: [Bug 237868] Serialize grid-template correctly : [Attachment 454752] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Matt Woodrow
<mattwoodrow at apple.com>'s request for review:
Bug 237868: Serialize grid-template correctly
https://bugs.webkit.org/show_bug.cgi?id=237868

Attachment 454752: Patch

https://bugs.webkit.org/attachment.cgi?id=454752&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 454752
  --> https://bugs.webkit.org/attachment.cgi?id=454752
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454752&action=review

> Source/WebCore/css/StyleProperties.cpp:835
> +    && downcast<CSSPrimitiveValue>(value.get())->valueID() == CSSValueNone;

Nit: We indent this line

> Source/WebCore/css/StyleProperties.cpp:837
> +}
> +static bool isValueID(const Ref<CSSValue>& value, CSSValueID id)

Nit: Need a blank line between these (and others)