[webkit-reviews] review granted: [Bug 238319] Implement ServiceWorkerWindowClient.focus : [Attachment 455747] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 238319: Implement ServiceWorkerWindowClient.focus
https://bugs.webkit.org/show_bug.cgi?id=238319

Attachment 455747: Patch

https://bugs.webkit.org/attachment.cgi?id=455747&action=review




--- Comment #7 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 455747
  --> https://bugs.webkit.org/attachment.cgi?id=455747
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455747&action=review

>> Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:840
>> +	// FIXME: We probably need to call a delegate instead of doing this
directly here.
> 
> This is the part where I am not exactly sure what we should do.
> My guess is that we should let know the application we want to switch to that
tab using a particular delegate (maybe with a default implementation if the
delegate is not implemented).
> This default implementation works for me on MacOS.

Let's add a new UI delegate method to call if implemented.
But if the client doesn't implement it, do the default thing.

R+ with that.