[webkit-reviews] review granted: [Bug 238293] [WebAuthn] Maintain last modification time separate from last used time for platform credentials : [Attachment 455567] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 238293: [WebAuthn] Maintain last modification time separate from last used
time for platform credentials
https://bugs.webkit.org/show_bug.cgi?id=238293

Attachment 455567: Patch

https://bugs.webkit.org/attachment.cgi?id=455567&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 455567
  --> https://bugs.webkit.org/attachment.cgi?id=455567
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455567&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:285
> +	       attributes[bridge_cast(kSecAttrModificationDate)],
_WKLocalAuthenticatorCredentialLastUsedDateKey,

It's kind of strange that we are using kSecAttrModifiedationDate to hold the
_WKLocalAuthenticatorCredentialLastUsedDateKey. I guess this is a limitation of
the Security framework API we are using?