[webkit-reviews] review granted: [Bug 238298] [GPU Process] RemoteRenderingBackend::stopListeningForIPC() should not change the RemoteResourceCache on the main thread : [Attachment 455734] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 238298: [GPU Process] RemoteRenderingBackend::stopListeningForIPC() should
not change the RemoteResourceCache on the main thread
https://bugs.webkit.org/show_bug.cgi?id=238298

Attachment 455734: Patch

https://bugs.webkit.org/attachment.cgi?id=455734&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 455734
  --> https://bugs.webkit.org/attachment.cgi?id=455734
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455734&action=review

> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:123
> +    m_workQueue->dispatch([&] {
> +	   m_remoteResourceCache = {
m_gpuConnectionToWebProcess->webProcessIdentifier() };
> +	   m_renderingResourcesRequest = { };
> +    });
>      m_workQueue->stopAndWaitForCompletion();

I guess the idea here is that m_workQueue->dispatch() appends this item to the
work queue so that stopAndWaitForCompletion() will process it last, after any
existing work? Seems ok. Maybe the comment could make that clearer.