[webkit-reviews] review granted: [Bug 238208] Add css-typed-om color IDL skeletons : [Attachment 455548] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 238208: Add css-typed-om color IDL skeletons
https://bugs.webkit.org/show_bug.cgi?id=238208

Attachment 455548: Patch

https://bugs.webkit.org/attachment.cgi?id=455548&action=review




--- Comment #6 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 455548
  --> https://bugs.webkit.org/attachment.cgi?id=455548
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455548&action=review

> Source/WebCore/css/typedom/color/CSSColor.h:42
> +    void setAlpha(CSSNumberish&& alpha) { m_alpha = WTFMove(alpha); }

You don't need (or I would argue want) the && here. (Same for all the other
uses outside of the template create use case. In general, most places really
don't require it).

> Source/WebCore/css/typedom/color/CSSHWB.h:47
> +    void setAlpha(CSSNumberish&& alpha) { m_alpha = WTFMove(alpha); }
> +private:

Missing newline.