[webkit-reviews] review granted: [Bug 237821] [AT-SPI] accessibility/native-text-control-attributed-string.html is failing : [Attachment 455721] Updated patch skipping out of range

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 25 01:24:46 PDT 2022


Carlos Garcia Campos <cgarcia at igalia.com> has granted Lauro Moura
<lmoura at igalia.com>'s request for review:
Bug 237821: [AT-SPI] accessibility/native-text-control-attributed-string.html
is failing
https://bugs.webkit.org/show_bug.cgi?id=237821

Attachment 455721: Updated patch skipping out of range

https://bugs.webkit.org/attachment.cgi?id=455721&action=review




--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 455721
  --> https://bugs.webkit.org/attachment.cgi?id=455721
Updated patch skipping out of range

View in context: https://bugs.webkit.org/attachment.cgi?id=455721&action=review

>
Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:116
9
> +    auto text = m_element->text();

You should also move m_element->updateBackingStore(); here, before calling
text().


More information about the webkit-reviews mailing list