[webkit-reviews] review granted: [Bug 238176] [JSC] Use Data CallIC in unlinked DFG : [Attachment 455709] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 238176: [JSC] Use Data CallIC in unlinked DFG
https://bugs.webkit.org/show_bug.cgi?id=238176

Attachment 455709: Patch

https://bugs.webkit.org/attachment.cgi?id=455709&action=review




--- Comment #8 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 455709
  --> https://bugs.webkit.org/attachment.cgi?id=455709
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455709&action=review

r=me with comments

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:836
> +		   GPRTemporary callLinkInfoTemp(this,
JITCompiler::selectScratchGPR(calleeGPR, GPRInfo::regT0));

This looks wrong to me. I think we want this GPRTemporary to stay around longer
than the scope of this if statement, otherwise we might reuse this register.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:889
> +	       GPRTemporary callLinkInfoTemp(this,
JITCompiler::selectScratchGPR(calleeGPR, GPRInfo::regT0));

This looks wrong to me. I think we want this GPRTemporary to stay around longer
than the scope of this if statement, otherwise we might reuse this register.