[webkit-reviews] review denied: [Bug 238349] AI should not set the structure for ObjectCreate : [Attachment 455689] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has denied Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 238349: AI should not set the structure for ObjectCreate
https://bugs.webkit.org/show_bug.cgi?id=238349

Attachment 455689: Patch

https://bugs.webkit.org/attachment.cgi?id=455689&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 455689
  --> https://bugs.webkit.org/attachment.cgi?id=455689
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455689&action=review

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:3138
>		   break;

You can’t break here. You need the below code to run and set our type.

I also suggest reworking this patch to never even bother looking up a structure
and just always mark things as shoyldTryCobstantFolding or instead to keep the
code as it used to be