[webkit-reviews] review granted: [Bug 238338] Web Inspector: Blank inspector in a page with container queries : [Attachment 455677] Patch v1.0

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 238338: Web Inspector: Blank inspector in a page with container queries
https://bugs.webkit.org/show_bug.cgi?id=238338

Attachment 455677: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=455677&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 455677
  --> https://bugs.webkit.org/attachment.cgi?id=455677
Patch v1.0

r=me, unfortunate that we have so many unchecked dereferences :(

I did do a bit of digging, and I wonder if something like
`window.getMatchedCSSRules(element)` will cause a crash if `element` has
matching container queries, since `StyleRuleType::Container` is not handled
inside `StyleRuleBase::createCSSOMWrapper`.  Might be worthing filing a
separate bug and replacing that FIXME with it (and maybe including similar
FIXME in relevant inspector code too).