[webkit-reviews] review granted: [Bug 238213] [XCBuild] "Migrated headers" scripts do not emit task information : [Attachment 455609] WebKit: Use native headers + build rules for migrated headers r5

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Elliott Williams
<emw at apple.com>'s request for review:
Bug 238213: [XCBuild] "Migrated headers" scripts do not emit task information
https://bugs.webkit.org/show_bug.cgi?id=238213

Attachment 455609: WebKit: Use native headers + build rules for migrated
headers r5

https://bugs.webkit.org/attachment.cgi?id=455609&action=review




--- Comment #19 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 455609
  --> https://bugs.webkit.org/attachment.cgi?id=455609
WebKit: Use native headers + build rules for migrated headers r5

View in context: https://bugs.webkit.org/attachment.cgi?id=455609&action=review

Elliott filed bug 238331 to investigate unifdef further. Sounds the rest is
uncontroversial, so r=me.

> Source/WebKit/Scripts/postprocess-header-rule:47
> +# TODO: rdar://90704735 (Run unifdef more uniformly on all WebKit.framework
headers)

Please reference bug 238331. Also, WebKit coding style calls for FIXME,
although there are a lot of TODOs that creeped in over the years, too.