[webkit-reviews] review granted: [Bug 238326] Add Captive Portal alert to WKWebView : [Attachment 455643] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted clopez1 at apple.com's request for
review:
Bug 238326: Add Captive Portal alert to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=238326

Attachment 455643: Patch

https://bugs.webkit.org/attachment.cgi?id=455643&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 455643
  --> https://bugs.webkit.org/attachment.cgi?id=455643
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455643&action=review

r=me

> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:1560
> +    [self _presentCaptivePortalModeAlertIfNeeded];

Views can move in and out of windows frequently, for example I believe they do
so when switching tabs. I recommend double-checking that
_presentCaptivePortalModeAlertIfNeeded is super efficient in the "do nothing"
case.